Merged
Conversation
Contributor
Author
|
@daogrady maybe you can take it from here. For local testing, make sure to install the plugin into capire: npm i .../eslint-plugin-cds --no-saveAlso use and check the playground link for the sample code. |
Contributor
There was a problem hiding this comment.
Spelling Mistakes
- tools/cds-lint/rules/no-shared-handler-variable.md:37:141 Unknown word "iteself"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
@smahati I think this should now be ready for review. I can no longer give a qualified review, as I have contributed content myself. Can you please give it a check for wording, formatting, and legibility? Thanks! |
daogrady
approved these changes
Aug 28, 2025
swaldmann
approved these changes
Aug 28, 2025
Contributor
Contributor
Contributor
renejeglinsky
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



First attempt for a rules details page
Missing: details on when the rule does not work, like code structures it does not detect.